django.shortcuts.get_list_or_404 unnecessarily returns a list

[Kamu]

django.shortcuts.get_list_or_404 returns a list, which prohibits queryset chaining etc. e.g.

stats = get_list_or_404(CityStats, country=countryid, snapshot=period).order_by('city__name')

is not possible due to the returning of a list. It is much better to return the queryset it makes in the first place!

(sorry if the patch is incorrectly formatted, as I am using git-svn and I am new to it, as well as diff/patches :))

[Kamu]

p.s. I understand the method name is get_list, but it seems silly to accept a queryset and return a list.

[Alex Gaynor]

I'm going to mark this as DDN for precisely the reason you mentioned.

[Malcolm Tredinnick]

Yes, the name tells you it will return a list. For it not to do so would mean the name was wrong.

It's a shortcut method for one simple case. You don't need it, so if you want something that returns a queryset, just do that and test for emptiness later.

[Dagur Páll Ammendrup]

The documentation needs to be fixed. get_list_or_404 is not equivalent to doing:

def my_view(request):

my_objects = MyModel.objects.filter(published=True)
if not my_objects:

raise Http404

because that would indeed return a queryset.

[Alex Gaynor]

Dagur, submit a seperate ticket for the docs patch, this ticket has already been marked as wontfix(correctly so).

[Jacob]

Milestone 1.0 deleted