#7250 closed (fixed)
Internal data shown when uploading a ImageField fails
| Reported by: | Marc Garcia | Owned by: | Marc Garcia |
|---|---|---|---|
| Component: | contrib.admin | Version: | newforms-admin |
| Severity: | Keywords: | nfa nfa-someday | |
| Cc: | marc.garcia@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
In newforms-admin, when uploading a file that isn't an image to a ImageField field, file internal data is display for "Currently". Shown data is something like {'content': '', 'content-type': 'text/plain', 'filename': 'test.txt'}
Same will happen if anything else fails when uploading to a FileField or a ImageField.
Attachments (1)
Change History (10)
comment:1 by , 16 years ago
| Keywords: | nfa-someday added |
|---|
comment:2 by , 16 years ago
| Has patch: | set |
|---|---|
| Needs tests: | set |
Cannot add tests with the patch because the difficulty in testing with files on the python shell.
I've tested the patch in the admin, but testing on forms and with ModelForm is still required.
This patch isn't supposed to modify the behavior of file deletion, but it would be recommended to check it.
comment:3 by , 16 years ago
| milestone: | → 1.0 |
|---|
comment:4 by , 16 years ago
| Description: | modified (diff) |
|---|
comment:5 by , 16 years ago
| Keywords: | fs-rf removed |
|---|
The filestorage refactor isn't dealing with the forms side of things. While this probably does need to be addressed, it's not part of fs-rf, so I'm removing the keyword.
comment:6 by , 16 years ago
| Cc: | added; removed |
|---|---|
| Owner: | changed from to |
comment:7 by , 16 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:8 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Not pretty but not a deal-breaker for merge to trunk.