ModelForm save method should take an optional dictionary.

[Peter of the Norse <RahmCoff@…>]

The only time we use save(commit=False) is when there are fields in the model that aren’t in the form. There are a lot of places where it looks like

form = SomeForm(request.POST)
instance = form.save(commit=False)
instance.other_field = "some value"
instance.another_field = calulated_value()
instance.save()

There are literally dozens of places where I have that, but no other places that use commit=False. It would be better if there was a way to pass a dictionary of values like form.save(extra = {"other_field": "some value", "another_field": calculated_value()})

[jkocherhans]

You can create your instance before passing it into a ModelForm. I use this method almost exclusively.

obj = MyModel(
    other_field = "some value"
    another_field = calulated_value()
)
form = SomeForm(request.POST, instance=obj)
new_obj = form.save()

[Peter of the Norse <RahmCoff@…>]

It took me a while to get back to my Django project, but you’re right, this is a much better way.