Invalid Cookies cause Stacktrace in middleware

[Michael Axiak]

If someone uses SessionMiddlware, any request with invalid cookies will result in a stack trace. For instance, someone visited a site with the cookie "lang:xml=ru".

If one were to use wget, you can repeat this on a number of sites:

 $ wget --header "Cookie: lang:xml=ru" http://www.djangoprojects.com
--09:06:39--  http://www.djangoproject.com/
           => `-'
Resolving www.djangoproject.com... 64.207.133.18
Connecting to www.djangoproject.com|64.207.133.18|:80... connected.
HTTP request sent, awaiting response... 500 Internal Server Error
09:06:40 ERROR 500: Internal Server Error.

(It's also amazing how many Django developers are lazy enough to leave PythonDebug on, but that's not fixable.)

Attached is a patch to have invalid cookies result in no cookies at all, along with a test.

Someone might decide to emit a warning or something, that's not included in this patch.

[Michael Axiak]

Patch to squelch cookie parsing errors.

[Michael Axiak]

I guess this is a dupe of #6507, though I'm not sure I agree that there needs to be a way to get some of the keys if one of them is bad. (Hence the need for subclassing the Morsel and Cookie class)

[Malcolm Tredinnick]

#6507 is overkill for this problem.

[Malcolm Tredinnick]

(In [7257]) Fixed #6764 -- Added some error checking around cookie decoding. Thanks,
Michael Axiak.