Opened 17 years ago

Closed 17 years ago

#6492 closed (fixed)

isValidFloat() should handle Unicode data

Reported by: Bastian Kleineidam <calvin@…> Owned by: nobody
Component: Template system Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The isValidFloat() can receive Unicode data in which case str() fails.
The patch uses smart_str() to cope with this.

Attachments (2)

0023-isValidFloat-should-handle-Unicode-data.patch​ (1.3 KB ) - added by Bastian Kleineidam <calvin@…> 17 years ago.
django-isvalidfloat-test.diff​ (684 bytes ) - added by Bastian Kleineidam <calvin@…> 17 years ago.
unittest for isValidFloat() unicode fix

Download all attachments as: .zip

Change History (7)

by Bastian Kleineidam <calvin@…>, 17 years ago

Attachment: 0023-isValidFloat-should-handle-Unicode-data.patch​ added

comment:1 by anonymous, 17 years ago

Component: Uncategorized → Template system

comment:2 by Chris Beaven, 17 years ago

Needs tests: set
Triage Stage: Unreviewed → Accepted

Straight-forwards patch, but may as well have a regression test...

by Bastian Kleineidam <calvin@…>, 17 years ago

Attachment: django-isvalidfloat-test.diff​ added

unittest for isValidFloat() unicode fix

comment:3 by Bastian Kleineidam <calvin@…>, 17 years ago

Needs tests: unset

comment:4 by Chris Beaven, 17 years ago

Triage Stage: Accepted → Ready for checkin

Good good (next time, just combine the tests with the actual fix into one patch)

comment:5 by Malcolm Tredinnick, 17 years ago

Resolution: → fixed
Status: new → closed

(In [7258]) Fixed #6492 -- Added bullet-proofing to isValidFloat validator. Thanks, Bastian Kleineidam.

Note: See TracTickets for help on using tickets.
Back to Top