[patch] Check for file permissions for proper error messages

[mbeachy@…]

This is a duplicate to #1194 with a simpler fix that only affects debug.py.

This problem bit me earlier today (in my first django installation) and while it wasn't *that* hard to figure out it would've saved me a good 20 minutes of poking around. Think of the newbies!

Also, FWIW the non-readability of templates was caused by a too-restrictive umask (0027) on my part; apparently data file installation from setup.py copies without modifying permissions, so I was stuck.

[mbeachy@…]

simple debug.py patch to report non-readability of template files

[Chris Beaven]

Interesting idea. Seems like a good one, but I'll pass via design decision.

[Simon Willison]

I spent half an hour debugging this exact problem a while ago - having the debug view highlight it is an excellent idea.

[Carl Meyer]

This seems like a useful feature that can be added in just a few lines of code.

[Łukasz Rekucki]

Updated patch: ​https://github.com/django/django/pull/443

[Claude Paroz]

Looks good, but I still think that this should be tested.

[Łukasz Rekucki]

Eh, I have a hard time testing this on Windows (can't set a file unreadable). Will update the patch next week.

[Mathijs de Bruin]

Have merged with master and running tests right now: ​https://travis-ci.org/dokterbob/django/builds/5020749

​https://github.com/dokterbob/django/tree/ticket6412

Note: Yes, Travis support will be rebased out in the definitive patch.

[Mathijs de Bruin]

Tests are failing on Python 3.x due to errors with StringIO. Attempting to fix now.

[Mathijs de Bruin]

Waiting for ​https://travis-ci.org/dokterbob/django/builds/5021135

Todo: shorten commit line.

[Mathijs de Bruin]

Build passed: ​https://travis-ci.org/dokterbob/django/builds/5021135

Fixed import issue in Python 3.x related to StringIO import in the process.

​https://github.com/django/django/pull/838

[Mathijs de Bruin]

Better have a review first.

[Markus Holtermann]

I tested the linked pull request (​https://github.com/django/django/pull/838) on Python 2.7.3 and Python 3.3.0 with Linux. The tests pass for both versions.

[Jannis Leidel]

The patch looks almost good, although using a NamedTemporaryFile would be better.

[Markus Holtermann]

I updated the patch to use the NamedTemporaryFile for the former two tests. The latter works on a directory, hence there is no way to automatically remove that directory.

​https://github.com/django/django/pull/947

[Markus Holtermann]

I updated the pull request to fix some PEP-8 issues. ​https://github.com/django/django/pull/947

[Ulrich Petri]

Patch looks good. I would prefer it if the messages were not defined in the view. But since this is the debug view the template is included in the same file anyway so this is no big deal.

[Aymeric Augustin <aymeric.augustin@…>]

In 61a8de6f4f547518d217a5ff959cbd57bddf4bb0:

Fixed #6412 -- More details if a template file cannot be loaded

Report more details about template files in loader postmortem.