Opened 17 years ago

Closed 17 years ago

Last modified 13 years ago

#6340 closed Uncategorized (wontfix)

auth.logout view doesn't use LOGOUT_URL in settings.py

Reported by: Alper KANAT <alperkanat@…> Owned by: David Tulig
Component: Generic views Version: dev
Severity: Normal Keywords: auth, view, logout
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

title says it all :)

Attachments (1)

logout_url.diff (2.3 KB ) - added by David Tulig 17 years ago.
Adds LOGOUT_URL support to the logout view.

Download all attachments as: .zip

Change History (6)

comment:1 by David Tulig, 17 years ago

Has patch: set
Owner: changed from nobody to David Tulig
Status: newassigned

by David Tulig, 17 years ago

Attachment: logout_url.diff added

Adds LOGOUT_URL support to the logout view.

comment:2 by Simon Greenhill <dev@…>, 17 years ago

Triage Stage: UnreviewedReady for checkin

comment:3 by Malcolm Tredinnick, 17 years ago

Settings should never be used at import time, which means don't use them as default arguments for functions. Otherwise you cannot import those modules without having already configured settings, which is inconvenient.

comment:4 by Malcolm Tredinnick, 17 years ago

Resolution: wontfix
Status: assignedclosed

Looking at this more closely, I think it's a wontfix. The logout() method, by default, displays a particular page (it doesn't do a redirect). If you want it to do a redirect, you can pass in the URL to redirect to, so the functionality is already possible. This patch would just change the default to be a redirect, which isn't necessarily a clear win, so would be a backwards incompatible change that would be more annoying than useful. Since either behaviour is possible at the moment, let's leave it alone.

comment:5 by dana@…, 13 years ago

Easy pickings: unset
Severity: Normal
Type: Uncategorized
UI/UX: unset

Maybe a note about this in the documentation would be appropriate as if there is a LOGOUT_URL setting but it doesn't do anything could be bit confusing for new users...

Note: See TracTickets for help on using tickets.
Back to Top