Opened 17 years ago

Closed 16 years ago

#6109 closed (fixed)

Fieldset description is autoescaped in admin

Reported by: Øyvind Saltvik <oyvind@…> Owned by: nobody
Component: contrib.admin Version: dev
Severity: Keywords: autoescaped fieldset
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

​http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/templates/admin/change_form.html#L37

Should add a |safe for the description since the docs says it should not be escaped

Attachments (1)

description_autoescape.diff​ (880 bytes ) - added by SomeGuy <SomeGuy@…> 17 years ago.

Download all attachments as: .zip

Change History (7)

by SomeGuy <SomeGuy@…>, 17 years ago

Attachment: description_autoescape.diff​ added

comment:1 by SomeGuy <SomeGuy@…>, 17 years ago

Has patch: set
Triage Stage: Unreviewed → Accepted

comment:2 by Chris Beaven, 17 years ago

Triage Stage: Accepted → Ready for checkin

Yep, the docs clearly state that it shouldn't be escaped: ​http://www.djangoproject.com/documentation/model-api/#description

comment:3 by Malcolm Tredinnick, 17 years ago

Resolution: → fixed
Status: new → closed

(In [7078]) Fixed #6109 -- Marked fieldset descriptions as safe from auto-escaping. Good
catch, SomeGuy.

comment:4 by Luke Plant, 16 years ago

Resolution: fixed
Status: closed → reopened

comment:5 by Luke Plant, 16 years ago

This is broken again, since newforms-admin was merged I think.

comment:6 by Luke Plant, 16 years ago

Resolution: → fixed
Status: reopened → closed

(In [8073]) Fixed #6109 again.

Note: See TracTickets for help on using tickets.
Back to Top