#6086 closed (fixed)
Refactor django.core.cache to deprecate "simple" backend
| Reported by: | Paul Bissex | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Cache system) | Version: | dev |
| Severity: | Keywords: | sprintdec01 | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
As detailed in this django-dev thread, the "simple" cache backend doesn't have much reason to live any more.
The attached patch refactors the cache backends to eliminate simple.py, and issues a DeprecationWarning per Jacob's recommendation.
Thanks to Brian Johnson and David Schein for a great afternoon of cafe coding!
Attachments (5)
Change History (10)
by , 17 years ago
| Attachment: | simple_cache_deprecate.diff added |
|---|
comment:1 by , 17 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 17 years ago
Cool. Also, we found a test (test_data_types) that did not actually test anything, and fixed that. (Patch attached.)
by , 17 years ago
| Attachment: | cache_test_fix.diff added |
|---|
by , 17 years ago
| Attachment: | global_settings_locmem.diff added |
|---|
Patch to make global_settings.py use "locmem" instead of "simple", per Malcolm's comment
comment:3 by , 17 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
This looks good to me. I've combined the above in to a single patch for convenience. Ready for checkin pending review.
by , 17 years ago
| Attachment: | rm_simple.diff added |
|---|
Sorry - original patch didn't include removal of simple.py
by , 17 years ago
| Attachment: | 6086_combined_patch.diff added |
|---|
Updating combined diff to include rm_simple.diff (patch with -p1)
comment:4 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Django's global_settings.py file still refers to "simple:///", so that should be fixed. Otherwise, the patch looks good. Fix the last thing and it's ready-for-checkin.