Opened 17 years ago
Closed 16 years ago
#6075 closed (fixed)
max_num, etc. for inline models in newforms-admin
| Reported by: | Yves Serrano | Owned by: | Brian Rosner |
|---|---|---|---|
| Component: | contrib.admin | Version: | newforms-admin |
| Severity: | Keywords: | nfa-blocker | |
| Cc: | densetsu.no.ero.sennin@…, brooks.travis@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | yes | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
The max_num feature is missing in the newforms-admin branch. When you add max_num to your Child_Inline max_num doesn't do anything.
from django.contrib import admin
class Child_Inline(admin.TabularInline):
model = Child
extra = 3
max_num = 5
I looked at the code in django/contrib/admin/options.py and it seems that there is no max_num feature there.
I added a patch with the missing functionality. I'm not sure if it's the best way to do it, especially the line with apply in it.
Attachments (2)
Change History (7)
by , 17 years ago
| Attachment: | newforms-admin_max_num.diff added |
|---|
comment:1 by , 17 years ago
| Keywords: | nfa-blocker added |
|---|---|
| Needs documentation: | set |
| Needs tests: | set |
| Patch needs improvement: | set |
| Summary: | max_num for inline models in newforms-admin → max_num, etc. for inline models in newforms-admin |
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 17 years ago
| Cc: | added |
|---|
by , 17 years ago
| Attachment: | newforms-admin_max_num_6075_v7363.diff added |
|---|
Updated patch for django version 7363 (should work for versions from 7270)
comment:3 by , 17 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:4 by , 17 years ago
| Cc: | added |
|---|
Seems like whatever is done to add this feature to the admin should probably be abstracted to the InlineFieldset portion of newforms, rather than living in contrib.admin, as it would be just as useful there.
comment:5 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
It doesn't look like any of the (max_num_in_admin, min_num_in_admin, num_extra_on_change, num_in_admin) described in the old admin doc (here: http://www.djangoproject.com/documentation/model-api/#many-to-one-relationships) have been implemented in newforms-admin. Rather than adding them one at a time it would make more sense to have one ticket cover them all. Marking this blocking on merge since it's a loss of capability from old admin. When implemented doc will be needed to describe any changes in the names of these things, and tests would be good too.