#6069 closed (wontfix)
Fix auto-escaping Password-Change-Link in Admin
| Reported by: | anonymous | Owned by: | anonymous |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Keywords: | admin, escaping, sprintdec01 | |
| Cc: | thomas-django@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Auto-escaping broke Password-Change link in Admin.
Attachments (2)
Change History (15)
by , 17 years ago
| Attachment: | 6777-escaping.patch added |
|---|
comment:1 by , 17 years ago
| Cc: | added |
|---|---|
| Has patch: | set |
| Owner: | changed from to |
| Status: | new → assigned |
comment:2 by , 17 years ago
comment:4 by , 17 years ago
| Owner: | changed from to |
|---|---|
| Status: | assigned → new |
comment:5 by , 17 years ago
| Summary: | Fix auto-esacaping Password-Change-Link in Admin → Fix auto-escaping Password-Change-Link in Admin |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:6 by , 17 years ago
| Status: | new → assigned |
|---|
comment:7 by , 17 years ago
| Keywords: | sprint1dec added |
|---|
comment:8 by , 17 years ago
| Keywords: | sprintdec1 added; sprint1dec removed |
|---|
comment:9 by , 17 years ago
| Owner: | changed from to |
|---|---|
| Status: | assigned → new |
comment:10 by , 17 years ago
| Keywords: | sprintdec01 added; sprintdec1 removed |
|---|
changed sprint keyword to match the others
comment:11 by , 17 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
This isn't necessary. Help text should never be auto-escaped. Is this still an issue after [6781]?
If this is still a bug on trunk, there should be some kind of template fix marking the help_text output as "safe", not a patch required to the model text.
comment:12 by , 17 years ago
I can't replicate the problem with trunk r6805. Help text for the password form shows up fine, with a working link.
Note:
See TracTickets
for help on using tickets.
_(mark_safe('string')) looks wrong to me - I think it should be mark_safe(_('string'))