RuntimeError when printing a SafeString

[Jan Rademaker <j.rademaker@…>]

SafeString's __str__ method does not return a string but the SafeString object itself. Simply removing the __str__ method seems to solve the problem (all tests pass).

>>> from django.newforms.util import ErrorList
>>> e = ErrorList([u'foo'])
>>> e
[u'foo']
>>> type(str(e))
<class 'django.utils.safestring.SafeString'>
>>> print e
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
RuntimeError: print recursion

[Thomas Güttler <hv@…>]

I can reproduce this and the patch solves the problem.

[trey@…]

I have verified that all the tests pass as well. Talked to Malcom and this seems to be an appropriate solution.

[Trey]

Replying to trey@ktrl.com:

I have verified that all the tests pass as well. Talked to Malcom and this seems to be an appropriate solution.

Let me try that while logged in.

[Malcolm Tredinnick]

(In [6807]) Fixed #6021 -- Removed some brain damage from SafeString. Not quite sure what I
was smoking there. Thanks, Jan Rademaker.

[Karen Tracey <kmtracey@…>]

Could this possibly be what caused the "Exception Value: maximum recursion depth exceeded Exception Location: usr/local/lib64/python2.5/site-packages/django/utils/safestring.py in __add__, line 73" reported in #6071?

[Malcolm Tredinnick]

Karen: no. That's more brain damage on my part. Trey also fixed that yesterday and I'll commit it shortly.