Opened 17 years ago

Closed 17 years ago

#5894 closed (fixed)

FilePathField needs to be updated to newforms

Reported by: Alex Gaynor Owned by: Jacob
Component: Forms Version: dev
Severity: Keywords: FilePathField
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

FilePathField still Old Forms in newforms-admin

Attachments (11)

diff.diff​ (2.2 KB ) - added by Alex Gaynor 17 years ago.
Newforms didn't have a filepath field, so I have created one, this should be the first step to fixing the admin, I think
diff.2.diff​ (1.1 KB ) - added by Alex Gaynor 17 years ago.
Here is the admin field
diff.3.diff​ (3.2 KB ) - added by Alex Gaynor 17 years ago.
Both diffs in one!
diff.4.diff​ (3.1 KB ) - added by Alex Gaynor 17 years ago.
Putting the max_length back into kwargs
diff.5.diff​ (3.9 KB ) - added by Alex Gaynor 17 years ago.
Adds docs, fixes a few small things
diff.6.diff​ (5.3 KB ) - added by Alex Gaynor 17 years ago.
diff.7.diff​ (5.3 KB ) - added by Alex Gaynor 17 years ago.
Fixes a stupid typo from the previous version
diff.8.diff​ (5.3 KB ) - added by Alex Gaynor 17 years ago.
Fixed the tests
diff.9.diff​ (5.5 KB ) - added by Alex Gaynor 17 years ago.
Refixed the tests, and made the patch more PEP8(thanks brosner)
diff.10.diff​ (6.3 KB ) - added by Alex Gaynor 17 years ago.
Added 2 more test cases
diff.11.diff​ (6.3 KB ) - added by Alex Gaynor 17 years ago.
Fixed a bug introduced last patch

Download all attachments as: .zip

Change History (19)

by Alex Gaynor, 17 years ago

Attachment: diff.diff​ added

Newforms didn't have a filepath field, so I have created one, this should be the first step to fixing the admin, I think

comment:1 by Alex Gaynor, 17 years ago

Has patch: set

by Alex Gaynor, 17 years ago

Attachment: diff.2.diff​ added

Here is the admin field

comment:2 by Brian Rosner, 17 years ago

Component: Admin interface → django.newforms
Keywords: newforms-admin removed
Patch needs improvement: set
Summary: FilePathField still uses Old Forms in newforms-admin → FilePathField needs to be updated to newforms
Version: newforms-admin → SVN

This is actually a bug in newforms and not just newforms-admin. newforms-admin is effected because it uses newforms in the admin.

by Alex Gaynor, 17 years ago

Attachment: diff.3.diff​ added

Both diffs in one!

by Alex Gaynor, 17 years ago

Attachment: diff.4.diff​ added

Putting the max_length back into kwargs

comment:3 by Chris Beaven, 17 years ago

Needs documentation: set
Needs tests: set
Patch needs improvement: unset
Triage Stage: Unreviewed → Accepted

by Alex Gaynor, 17 years ago

Attachment: diff.5.diff​ added

Adds docs, fixes a few small things

comment:4 by Alex Gaynor, 17 years ago

Needs documentation: unset

by Alex Gaynor, 17 years ago

Attachment: diff.6.diff​ added

comment:5 by Alex Gaynor, 17 years ago

Needs tests: unset

There are now tests.

by Alex Gaynor, 17 years ago

Attachment: diff.7.diff​ added

Fixes a stupid typo from the previous version

by Alex Gaynor, 17 years ago

Attachment: diff.8.diff​ added

Fixed the tests

by Alex Gaynor, 17 years ago

Attachment: diff.9.diff​ added

Refixed the tests, and made the patch more PEP8(thanks brosner)

by Alex Gaynor, 17 years ago

Attachment: diff.10.diff​ added

Added 2 more test cases

by Alex Gaynor, 17 years ago

Attachment: diff.11.diff​ added

Fixed a bug introduced last patch

comment:6 by Brian Rosner, 17 years ago

Triage Stage: Accepted → Ready for checkin

comment:7 by Jacob, 17 years ago

Owner: changed from nobody to Jacob

comment:8 by Jacob, 17 years ago

Resolution: → fixed
Status: new → closed

(In [7323]) Fixed #5894: added FilePathField to newforms. Thanks, Alex Gaynor.

Note: See TracTickets for help on using tickets.
Back to Top