[patch] fix many-to-many with non-default pks.

[rjwittams]

I found that many to many fields do not work when the primary keys of the objects are not default.
As I'm working in the new-admin branch and this is an obvious fix, I thought I'd point it up here so
it can be applied to trunk.

def method_set_related_many_to_many(rel_opts, rel_field, self, id_list):
    id_list = map(int, id_list) # normalize to integers
    rel = rel_field.rel.to
    m2m_table = rel_field.get_m2m_db_table(rel_opts)
    this_id = getattr(self, self._meta.pk.column)
    cursor = db.db.cursor()
    delete_stmt = "DELETE FROM %s WHERE %s = %%s" % (m2m_table, rel.pk.column)
    cursor.execute(delete_stmt, [this_id])
    insert_stmt = "INSERT INTO %s (%s, %s) VALUES (%%s, %%s)" % (m2m_table, rel.pk.column, rel_opts.pk.column)
    cursor.executemany(insert_stmt, [(this_id, i) for i in id_list])
    db.db.commit()

[Adrian Holovaty]

This is a duplicate of #556 and was fixed in [682]. Maybe [682] didn't get applied to your new-admin branch?

[rjwittams]

Sorry, that fix won't work.

Look at the original version of this function.

[rjwittams]

​http://code.djangoproject.com/browser/django/trunk/django/core/meta/__init__.py#l901

[Adrian Holovaty]

Could you clarify, please?

[rjwittams]

Hm, well 684 is before my branch started.
I can see how that is supposed to work to work now.
I don't get how my fix worked with this change in place as well.....

[Adrian Holovaty]

I just realized the fix in [682] was to method_set_many_to_many(), whereas you're pointing out method_set_related_many_to_many().

[(none)]

Milestone Version 1.0 deleted