#5695 closed (fixed)
[newform-admin] - i18n and xhtml problem in AdminFileWidget
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.admin | Version: | newforms-admin |
| Severity: | Keywords: | nfa-blocker AdminFileWidget i18n invalid html | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Improvements introduced in [6457] are not internationalized and are not xhtml compatible.
Attachments (2)
Change History (8)
by , 17 years ago
| Attachment: | admin-file-widget.diff added |
|---|
comment:1 by , 17 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
comment:2 by , 17 years ago
| Cc: | added |
|---|---|
| Component: | Internationalization → Admin interface |
| Keywords: | AdminFileWidget i18n invalid html added |
Previous patch improved:
- target="_blank" isn't valid in xhtml strict, changed to javascript
- Translatable labels not including colon
- Tests added
comment:3 by , 17 years ago
| Keywords: | nfa-blocker added |
|---|
This is pretty trivial and does need to be fixed before a merge to trunk. Tagging nfa-blocker.
comment:4 by , 17 years ago
I am going to fix this, but can the target="_blank" stuff be opened in a new ticket. I would rather deal with that separately.
comment:5 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:6 by , 17 years ago
| Cc: | removed |
|---|
Thanks for commiting.
Your ticket for target="_blank" is #6750
Note:
See TracTickets
for help on using tickets.
Looks good to me. Marking as Ready for checkin.