Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#5581 closed (wontfix)

allow translation of javascript in any folder of the project

Reported by: Benoit Chesneau <bchesneau@…> Owned by: nobody
Component: Internationalization Version: dev
Severity: Keywords: javascript locale translation
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Currently javascript locale folder is set by applications folder in INSTALLED_APP or django.conf you can't use project root locale folder.

Here is a quick patch to solve it.

Attachments (2)

views_i18n_py.patch (1.3 KB ) - added by Benoit Chesneau <bchesneau@…> 17 years ago.
patch-views_i18n_py (524 bytes ) - added by Benoit Chesneau <bchesneau@…> 17 years ago.
add media folder to javascript catalog in i18n

Download all attachments as: .zip

Change History (9)

by Benoit Chesneau <bchesneau@…>, 17 years ago

Attachment: views_i18n_py.patch added

comment:1 by Chris Beaven, 17 years ago

Component: Generic viewsInternationalization
Has patch: set
Patch needs improvement: set

comment:2 by Jacob, 17 years ago

Resolution: wontfix
Status: newclosed

This is deliberate. We don't want translations from non-installed-apps "leaking" into other apps. INSTALLED_APPS is the standard mechanism by which Django discovers stuff, and changing that just for i18n doesn't make a whole lot of sense.

comment:3 by Benoit Chesneau <bchesneau@…>, 17 years ago

Resolution: wontfix
Status: closedreopened

you forget js files in media folder by doing this. The possibility to have i18n in js is useless with current code. Maybe we could just filter js files. Wont fix current behaviour isn't the solution anyway. I will propose an alternative soon.

comment:4 by Jacob, 17 years ago

Resolution: wontfix
Status: reopenedclosed

Please don't reopen tickets that we've closed; if you need to discuss this further take it to django-dev.

by Benoit Chesneau <bchesneau@…>, 17 years ago

Attachment: patch-views_i18n_py added

add media folder to javascript catalog in i18n

comment:5 by Benoit Chesneau <bchesneau@…>, 17 years ago

maybe this patch is better. ok last time i will discuss it before. anyway a ticket system is also a good way to discuss a patch and maybe before closing could you also discuss it with its author...

comment:6 by Jacob, 17 years ago

With all due respect, a ticket system is a pretty bad place for discussions -- only you and I are really paying attention to this, and I'm far from the final word on things (especially i18n). That's why our guide to contributing to Django requests that ticket discussions happen on django-dev.

No need to be all passive-agressive here; if you don't agree with me, say so. I'm trying to help you do it in a place where you might get some support for your position.

comment:7 by Benoit Chesneau <bchesneau@…>, 17 years ago

not agressive, just a little disappointed about the current system. Anyway right, no need to complain I will post about this pb on ml.

Note: See TracTickets for help on using tickets.
Back to Top