Opened 17 years ago
Closed 17 years ago
#5251 closed (fixed)
[newforms-admin] "Show in Web" links not working
Reported by: | Florian Apolloner | Owned by: | Florian Apolloner |
---|---|---|---|
Component: | contrib.admin | Version: | newforms-admin |
Severity: | Keywords: | newforms-admin reverse sprintsept14 | |
Cc: | django@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The "Show in Web" Links on the change pages of the django admin are not working as admin/r/10/1 (just an example) returns "app u'r', model 10 (or something like it ;)) not found"...
This patch moves the checking to contrib/admin/sites to prevent this special url from getting displayed as model_page which obviously fails...
Attachments (2)
Change History (9)
by , 17 years ago
Attachment: | show_in_web-6000.diff added |
---|
comment:1 by , 17 years ago
Summary: | [newforms-admin][patch] "Show in Web" links not working → [newforms-admin] "Show in Web" links not working |
---|---|
Triage Stage: | Unreviewed → Ready for checkin |
comment:2 by , 17 years ago
Patch needs improvement: | set |
---|---|
Triage Stage: | Ready for checkin → Accepted |
comment:3 by , 17 years ago
Patch needs improvement: | unset |
---|
comment:4 by , 17 years ago
I don't think it can be moved, as admin.site.root tries to call model_page, but my new patch is better :)
comment:5 by , 17 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:6 by , 17 years ago
Keywords: | sprintsept14 added; /admin/r/ removed |
---|
comment:7 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
The special-casing in this patch isn't right. I think it can be fixed just be reordering the admin urlconf instead of this weird dispatch thing.