Opened 17 years ago
Closed 17 years ago
#5243 closed (fixed)
{% load %} does not load template tags inside sub-directories
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | Template system | Version: | dev |
Severity: | Keywords: | load | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
According to {% load %} you can load templatetags that are in subdirectories, e.g. {% load news.blah %}. This didn't work for me; I kept getting errors.
Applying the below patch seems to work. I don't know why taglib.split('.')[-1])
was done in the first place? It's been like this for as far back as I could trace the revisions in on this Trac. A related ticket might be #372.
Index: django/template/defaulttags.py =================================================================== --- django/template/defaulttags.py (revision 8271) +++ django/template/defaulttags.py (working copy) @@ -792,7 +792,7 @@ for taglib in bits[1:]: # add the library to the parser try: - lib = get_library("django.templatetags.%s" % taglib.split('.')[-1]) + lib = get_library("django.templatetags.%s" % taglib) parser.add_library(lib) except InvalidTemplateLibrary, e: raise TemplateSyntaxError, "'%s' is not a valid tag library: %s" % (taglib, e)
Attachments (1)
Change History (6)
by , 17 years ago
Attachment: | defaulttags.patch added |
---|
comment:2 by , 17 years ago
Has patch: | set |
---|---|
Summary: | Bug in {% load %} → {% load %} does not load template tags inside sub-directories |
Triage Stage: | Unreviewed → Ready for checkin |
comment:3 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:4 by , 17 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
For me this patch broke the loading in subdirectories
I am using nesh.thumbnail
in the template: {% load nesh.thumbnail %}
in the settings:
{{{INSTALLED_APPS = (
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.sessions',
'django.contrib.sites',
'django.contrib.admin',
'django.contrib.markup',
'django.contrib.flatpages',
'django.contrib.humanize',
'nesh.thumbnail',
)
}}}
comment:5 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
This change was a backward incompatible change. Please see http://code.djangoproject.com/wiki/BackwardsIncompatibleChanges#Templatetagloadingrespectsdottednotation for more information. Please take this to django-users or #django on freenode.
Patch to make {% load module.submodule %} work