Opened 17 years ago

Closed 14 years ago

Last modified 12 years ago

#4471 closed Uncategorized (wontfix)

Newforms errors.as_text probably shouldn't prefix the string with an '*' character

Reported by: zigiDev@… Owned by: nobody
Component: Forms Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

To make 

errors.as_text

more generic, it probably shouldn't prefix the returned string with an asterisk. This would give template authors more control over the formatting of error strings.

Attachments (1)

remove_stars_from_errors.diff​ (1.8 KB ) - added by Grant Kelly <gkelly@…> 17 years ago.

Download all attachments as: .zip

Change History (6)

by Grant Kelly <gkelly@…>, 17 years ago

Attachment: remove_stars_from_errors.diff​ added

comment:1 by Grant Kelly <gkelly@…>, 17 years ago

Has patch: set

comment:2 by Chris Beaven, 17 years ago

Triage Stage: Unreviewed → Design decision needed

comment:3 by yogi, 16 years ago

I know it's old, but it still (AFAIK) applies. Let's get rid of the asterisk! I think the diff needs to remove the extra space at the beginning too.

comment:4 by Malcolm Tredinnick, 14 years ago

Resolution: → wontfix
Status: new → closed

Would be backwards incompatible at this point. Making this change in your own code is easy enough, as it's possible to use a custom Error class on forms and the method can be subclassed.

comment:5 by nu.everest@…, 12 years ago

Easy pickings: unset
Severity: → Normal
Type: → Uncategorized
UI/UX: unset

How do I make a custom Error class on my form for 'non_field_errors' so that I can use {{ form.non_field_errors.as_text }} in my template without the silly '*' throwing off the qì (Ch'i) of my site?

Note: See TracTickets for help on using tickets.
Back to Top