django.contrib.webdesign's {% lorem N w %} fails where N >= 20

[Trent Mick <trentm@…>]

The code path handling inserting 20 or more lorem ipsum words (django/contrib/webdesign/lorem_ipsum.py: def words) ends up passing a negative number as the second argument to random.sample().

As well, the function would also fail if the requested word count was greater than len(WORDS). I have a patch that corrects this.

[Trent Mick <trentm@…>]

patch to fix the issues described

[Trent Mick <trentm@…>]

Note as well that the django/contrib/webdesign files should have the svn:eol-style=native property added to them:

cd django/contrib/webdesign
find . -name "*.py" | xargs svn ps svn:eol-style native

Cheers

[Malcolm Tredinnick]

(In [5189]) Added native eol-style settings to necessary files. Refs #4276.

[Malcolm Tredinnick]

Was the problem case you are referring to something like this:

{% lorem 32 w %}

I'm going to commit a slightly simpler patch that fixes this and close the ticket. If there's another example that fails, could you reopen and give the example. It's hard to write a test for this code, since the output is random, but I'd at least like to make sure we're fixing the right problem here.

[Malcolm Tredinnick]

(In [5190]) Fixed #4276 -- Fixed a crash in the lorem tag when more than 20 words were
requested.

[Malcolm Tredinnick]

Replying to mtredinnick:

Was the problem case you are referring to something like this:

{% lorem 32 w %}

Doh! That was the case mentioned in the ticket title. I was concentrating on the summary too much. Nothing to see here. Move along. :-(