Opened 18 years ago
Closed 18 years ago
#4018 closed (fixed)
Allow callable values as initial for newforms-fields
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | Forms | Version: | dev |
| Severity: | Keywords: | lazydate newforms initial callable | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Like in the model-fields this can be used to replace LazyDate, see http://groups.google.com/group/django-developers/msg/00bf8f4bf4bbc81c.
Attachments (2)
Change History (6)
by , 18 years ago
| Attachment: | django-make-initial-newforms-value-callable.diff added |
|---|
comment:1 by , 18 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
follow-up: 3 comment:2 by , 18 years ago
| Needs tests: | set |
|---|---|
| Triage Stage: | Ready for checkin → Accepted |
Yep, needs tests before it can go. The easy patches are the easiest ones to write tests for. There is no excuse.
by , 18 years ago
| Attachment: | django-make-initial-newforms-value-callable.2.diff added |
|---|
Patch including tests
comment:3 by , 18 years ago
| Needs tests: | unset |
|---|
Replying to mtredinnick:
Yep, needs tests before it can go. The easy patches are the easiest ones to write tests for. There is no excuse.
So the new patch includes some tests ;-)
comment:4 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Thanks David. Probably only other suggestion is that it could do with a test or two, but it's a simple enough patch that I won't let that hold up the process.