[patch] newforms SelectDateWidget fails to display saved values correctly, lacks 'blank' choices

[Jeff Hilyard <jhilyard@…>]

SelectDateWidget in newforms.extras.widgets displays January 1, 2007 regardless of value entered.
render() assumes the value parameter is a string but it is being passed a datetime.date.
It sets the year, month, day to None before rendering the individual select tags.

This minimally invasive patch works for me but should be rewritten by someone with knowledge of how things are supposed to be - if value is supposed to be a datetime.date then that case should probably be handled in the "try" not the "except" as I've done.

[Jeff Hilyard <jhilyard@…>]

patch to fix newforms.extras.widgets.SelectDateWidget render() bug

[Jeff Forcier <reg@…>]

Adds initial 'dashes' choices at the top of the dropdowns, as with regular select fields

[Jeff Forcier <reg@…>]

Sigh. Keep thinking the text field on the attachment page is going to be a file description instead of the comment body. This is what I really want to say:

I seem to be having this issue too. I don't have time right now to extensively investigate the issue, but I do want to be a parasite and attach my own diff to this ticket, for a very similar/related issue: if one wanted the fields to be blank, that's not possible at this point in time, as there are no dashes in the choice lists. My diff remedies this.

[Jeff Forcier <reg@…>]

Apologies for ticket spam.

[Simon Law <simon@…>]

Here is a patch that does the coersion only when value is a basestring.

Otherwise, we just assume it's either a datetime.date or datetime.datetime object. If it isn't, it makes sense to throw an exception.

[Simon Law <simon@…>]

Patch that only does coersion when value is a basestring.

[Matt Grayson]

The issue of displaying saved values correctly was fixed by #5917