Opened 18 years ago

Closed 16 years ago

#3759 closed (worksforme)

Community aggregator update_feed.py uses wrong encoding

Reported by: derelm Owned by: nobody
Component: *.djangoproject.com Version: dev
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I actually fell over that problem, when i duplicated the code in djangoproject.com/django_website/apps/aggregator/bin/update_feeds.py on my website. the fetched feed-data is converted back to the encoding it used to be instead of being converted to UTF-8.

i am not really into encodings that much, so i'd love to get a comment of someone with a little more knowledge in that area.

Attachments (1)

update_feeds.diff (1.3 KB ) - added by derelm 18 years ago.

Download all attachments as: .zip

Change History (6)

by derelm, 18 years ago

Attachment: update_feeds.diff added

comment:1 by Simon G. <dev@…>, 18 years ago

Triage Stage: UnreviewedDesign decision needed

comment:2 by Jacob, 17 years ago

Resolution: invalid
Status: newclosed

This doesn't look right to me... it assumes that all feeds are in UTF8, which is wrong.

comment:3 by derelm, 17 years ago

i tested it for quite some time with all sorts of feeds all over the web, works perfectly fine for me.

btw, also tested with non utf-8 feeds.

comment:4 by derelm, 17 years ago

Resolution: invalid
Status: closedreopened

it assumes that the output of feedparser is utf8 which is almost always true...

can someone from unicode-branch comment?

comment:5 by Jacob, 16 years ago

Resolution: worksforme
Status: reopenedclosed

The code works for this website, which is all it's intended for.

Note: See TracTickets for help on using tickets.
Back to Top