Opened 18 years ago
Closed 17 years ago
#3652 closed (worksforme)
ChoiceField formfield for IntegerField and CharField
| Reported by: | Owned by: | Craig Ogg | |
|---|---|---|---|
| Component: | Forms | Version: | dev |
| Severity: | Keywords: | newforms choicefield integerfield charfield | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
Patch for choicefields for model fields with choices.
Attachments (2)
Change History (6)
by , 18 years ago
| Attachment: | 4664-choicefield.patch added |
|---|
comment:1 by , 17 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
I'm not keen on how this changes ChoiceField, but I like the overall idea...
comment:2 by , 17 years ago
| Owner: | changed from to |
|---|
by , 17 years ago
| Attachment: | 6213-choicefield-test-only.patch added |
|---|
Only the unit test portion of patch against current version of trunk
follow-up: 4 comment:3 by , 17 years ago
I am not sure what was intended here, but it appears the requested functionality is already present because running the supplied test against the current trunk succeeds. I think this ticket should be closed as fixed or more explanation should be provided.
comment:4 by , 17 years ago
| Resolution: | → worksforme |
|---|---|
| Status: | new → closed |
Replying to cogg:
I am not sure what was intended here, but it appears the requested functionality is already present because running the supplied test against the current trunk succeeds. I think this ticket should be closed as fixed or more explanation should be provided.
Agreed; this seems to cover something that already works. If anyone can explain why this isn't so, please re-open with a more specific explanation.
ChoiceField patch