Opened 13 days ago

Closed 5 days ago

#36178 closed Cleanup/optimization (fixed)

Consistent quoting of object strings in admin delete confirmation messages.

Reported by: Antoliny Owned by: Antoliny
Component: contrib.admin Version: dev
Severity: Normal Keywords: delete
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

There is a confirmation message when removing a specific object on the Admin page.
Currently, there are three types of confirmation messages depending on the permissions and on_delete values like this..

As shown in the highlighted part of the image above, single quotes and double quotes are used to emphasize the str object.
I think it would be better to use either single double quotes or quotes consistently for uniformity(I think use double quotes is better).

Attachments (1)

delete_confirmation_message.png (103.8 KB ) - added by Antoliny 13 days ago.

Download all attachments as: .zip

Change History (10)

by Antoliny, 13 days ago

comment:1 by Antoliny, 13 days ago

Owner: set to Antoliny
Status: newassigned

comment:2 by Sarah Boyce, 12 days ago

Summary: Add quote consistency for object str emphasis in admin delete confirmation messages.Consistent quoting of object strings in admin delete confirmation messages.
Triage Stage: UnreviewedAccepted
UI/UX: set

This is likely to be the case in other pages also 👍

comment:3 by Antoliny, 12 days ago

Has patch: set

comment:4 by Mariusz Felisiak, 12 days ago

Patch needs improvement: set
Version: 5.1dev

comment:5 by Antoliny, 11 days ago

Patch needs improvement: unset

comment:6 by Raphael Gaschignard, 8 days ago

Triage Stage: AcceptedReady for checkin

Think there have been a good number of eyes on this, and I didn't find any other potential-smart-quote-needing spots.

comment:7 by Sarah Boyce, 8 days ago

Patch needs improvement: set
Triage Stage: Ready for checkinAccepted

I think we should also update translations as part of the change similar to 42b9a23267f14be39b9b00958e18d5746783208e (#30400)

comment:8 by Sarah Boyce, 8 days ago

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:9 by Sarah Boyce <42296566+sarahboyce@…>, 5 days ago

Resolution: fixed
Status: assignedclosed

In 2fa1f99:

Fixed #36178 -- Applied consistent object quoting in admin delete confirmation page.

Note: See TracTickets for help on using tickets.
Back to Top