#35832 closed Cleanup/optimization (duplicate)
use ruff for linting/formatting/sorting instead of black/flake8/isort
Reported by: | Ahmed Ibrahim | Owned by: | |
---|---|---|---|
Component: | Core (Other) | Version: | |
Severity: | Normal | Keywords: | linting, formatting, styling |
Cc: | Adam Johnson | Triage Stage: | Unreviewed |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
This will provide a performance boost, and it has most if not all the rules needed
Ruff URL: https://github.com/astral-sh/ruff
Comparison provided by ruff team
Ruff is faster than the 3 replacements combined
Change History (5)
comment:1 by , 5 weeks ago
Description: | modified (diff) |
---|
follow-up: 3 comment:2 by , 5 weeks ago
Cc: | added |
---|
comment:3 by , 5 weeks ago
Replying to Carlton Gibson:
I’m inclined to say this would need a community discussion on the Forum.
For what it’s worth, I would much prefer that we stick with community tools, rather than VC controlled alternatives.
Perhaps I’m alone in that concern. (I’d ask Adam’s take personally, and probably defer to that.)
Your opinion is always appreciated, this is just a suggestion, a recommendation, the first advantage we got is that if someone wants to ruff at some point, he will be able to see this ticket and get an answer
comment:4 by , 5 weeks ago
Component: | Uncategorized → Core (Other) |
---|---|
Resolution: | → duplicate |
Status: | new → closed |
Duplicate of #34460.
comment:5 by , 5 weeks ago
Happy to discuss on forum.
(I don't think the VC control is a concern: compare with how Flake8 is now basically one person. I am concerned that Ruff is still technically beta and its docs mostly defer to other project docs, making it a bit hard to understand if you don't know or follow the history.)
I’m inclined to say this would need a community discussion on the Forum.
For what it’s worth, I would much prefer that we stick with community tools, rather than VC controlled alternatives.
Perhaps I’m alone in that concern. (I’d ask Adam’s take personally, and probably defer to that.)