Opened 5 weeks ago

Closed 5 weeks ago

Last modified 5 weeks ago

#35832 closed Cleanup/optimization (duplicate)

use ruff for linting/formatting/sorting instead of black/flake8/isort

Reported by: Ahmed Ibrahim Owned by:
Component: Core (Other) Version:
Severity: Normal Keywords: linting, formatting, styling
Cc: Adam Johnson Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Ahmed Ibrahim)

This will provide a performance boost, and it has most if not all the rules needed
Ruff URL: https://github.com/astral-sh/ruff

Comparison provided by ruff team

https://i.imgur.com/MbRTKYL.png

Ruff is faster than the 3 replacements combined

Change History (5)

comment:1 by Ahmed Ibrahim, 5 weeks ago

Description: modified (diff)

comment:2 by Carlton Gibson, 5 weeks ago

Cc: Adam Johnson added

I’m inclined to say this would need a community discussion on the Forum.

For what it’s worth, I would much prefer that we stick with community tools, rather than VC controlled alternatives.
Perhaps I’m alone in that concern. (I’d ask Adam’s take personally, and probably defer to that.)

in reply to:  2 comment:3 by Ahmed Ibrahim, 5 weeks ago

Replying to Carlton Gibson:

I’m inclined to say this would need a community discussion on the Forum.

For what it’s worth, I would much prefer that we stick with community tools, rather than VC controlled alternatives.
Perhaps I’m alone in that concern. (I’d ask Adam’s take personally, and probably defer to that.)

Your opinion is always appreciated, this is just a suggestion, a recommendation, the first advantage we got is that if someone wants to ruff at some point, he will be able to see this ticket and get an answer

comment:4 by Tim Graham, 5 weeks ago

Component: UncategorizedCore (Other)
Resolution: duplicate
Status: newclosed

Duplicate of #34460.

comment:5 by Adam Johnson, 5 weeks ago

Happy to discuss on forum.

(I don't think the VC control is a concern: compare with how Flake8 is now basically one person. I am concerned that Ruff is still technically beta and its docs mostly defer to other project docs, making it a bit hard to understand if you don't know or follow the history.)

Note: See TracTickets for help on using tickets.
Back to Top