Assigning a file without a name property to a FileField results in file getting discarded silently

[john-parton]

If you assign a File object without a name (A ContentFile or otherwise) to an instance and then save it, the storage backend is not invoked, the data isn't persisted, and the column isn't updated. All without raising an error or even a logger message.

We've isolated the behavior here: ​https://github.com/john-parton/django-file-field-no-name/blob/dc557c641552b02623f50ef044d73435b9e97ead/test_app/tests.py#L28-L41

There's some discussion here: ​https://forum.djangoproject.com/t/setting-filefield-imagefield-where-file-has-no-name/30192/24
The general consensus is that some error should be raised.

I'll see if I can submit a patch. I flagged this as Database layer, because the patch will likely be in models.files, not the storage backend.

[Sarah Boyce]

Thank you for the analysis and discussions 👍

[Jonny Park]

The patch will still not pass test_can_reread_content_file at ​https://github.com/john-parton/django-file-field-no-name/blob/dc557c641552b02623f50ef044d73435b9e97ead/test_app/tests.py#L74-L83
I think it deserves it's own ticket and disccusion.

[Sarah Boyce <42296566+sarahboyce@…>]

In c0b0ce8:

Fixed #35384 -- Raised FieldError when saving a file without a name to FileField.