Opened 8 months ago
Closed 8 months ago
#35292 closed Cleanup/optimization (invalid)
Restore autofocus functionality to admin search box within popup interface
| Reported by: | Mattias L | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | 5.0 |
| Severity: | Normal | Keywords: | accessibility, screen reader, autofocus |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
After recently upgrading to Django 4, we've had users report issues related to the changes made in #34040. The users perform quite a lot of these searches, and an extra click to focus the search box annoys them. I wonder if it would be possible to restore the autofocus functionality when in popup? In the popup context, I think it makes sense to autofocus the search box since usability greatly improves.
Change History (3)
comment:1 by , 8 months ago
comment:2 by , 8 months ago
| Description: | modified (diff) |
|---|
comment:3 by , 8 months ago
| Keywords: | autofocus added; keyboard removed |
|---|---|
| Resolution: | → invalid |
| Status: | new → closed |
| Type: | Uncategorized → Cleanup/optimization |
Hello Mattias, thank you for your report.
We should confirm with the accessibility team if this is an acceptable proposal from the accessibility point of view. I do acknowledge that your PR proposes to restore the autofocus only when there is a popup, but it's unclear whether that will also be confusing screen readers.
My advice would be to reach out to them in the dedicated Accessibility category in the forum and seek approval for the proposal. Until then, I'll close the ticket as invalid, but if they do approve this idea, please point us to the discussion and we'll re-open.
PR up here: https://github.com/django/django/pull/17967