[patch] django.newforms.util.smart_unicode() is not smart enough :)

[Anton Khalikov <anton@…>]

Guys

django.newforms.util.smart_unicode() needs to be smarter to don't unicode None, True and False values and leave them as they are.

The patch is attached.

[Anton Khalikov <anton@…>]

Quick fix

[Anton Khalikov <anton@…>]

Sorry, forgot to name the subject properly.
As I always do :)

[Chris Beaven]

It's true that something needs to change so that unicode(s, settings.DEFAULT_CHARSET) doesn't choke on these types, but smart_unicode looks like it should always return a unicode object. Perhaps just str(s) if it's type is NoneType or bool.

[Anton Khalikov <anton@…>]

smart_unicode(None) -> u'None' -> try to save it in DB and guess what happened
same is for smart_unicode(True) -> u'True' -> same thing

[Malcolm Tredinnick]

Can you give an example of where the current behaviour is causing errors?

smart_unicode() is an equivalent of str() and unicode() in that it forces the result to be a string, intentionally. So not converting certain types is counter-intuitive behaviour.

Are there cases in the code where we are calling smart_unicode() on booleans or None and then expecting them to act as their original types? Those cases should be fixed, but the general fix in this ticket is not the right way to do it.