Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#34905 closed Bug (fixed)

Main landmark is on the wrong element

Reported by: Tom Carrick Owned by: ontowhee
Component: contrib.admin Version: 5.0
Severity: Release blocker Keywords: accessibility
Cc: Sarah Abderemane, Thibaud Colas Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

It's currently wrapping the navbar, but it should be inside. Main element should not have repeated content such as navigation that appears on multiple pages.

Change History (6)

comment:1 by Mariusz Felisiak, 13 months ago

Cc: Sarah Abderemane Thibaud Colas added
Easy pickings: set
Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted
Version: dev → 5.0

Thanks for the report! Regression in 91e617c743b21a0ebad01f18623a8b31f6f58500. We should change the #content-start div to the main landmark instead of #main.

comment:2 by ontowhee, 13 months ago

Owner: changed from nobody to ontowhee
Status: new → assigned

comment:3 by ontowhee, 13 months ago

Has patch: set

​PR

comment:4 by Mariusz Felisiak, 13 months ago

Triage Stage: Accepted → Ready for checkin

comment:5 by GitHub <noreply@…>, 13 months ago

Resolution: → fixed
Status: assigned → closed

In 89d2ae2:

Fixed #34905 -- Corrected admin's main content element rendered in <main> tag.

Regression in 91e617c743b21a0ebad01f18623a8b31f6f58500.

Thanks Tom Carrick for the report.

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 13 months ago

In 31bdf67a:

[5.0.x] Fixed #34905 -- Corrected admin's main content element rendered in <main> tag.

Regression in 91e617c743b21a0ebad01f18623a8b31f6f58500.

Thanks Tom Carrick for the report.
Backport of 89d2ae257bfdbe6f32c4671d97bf572623992ace from main

Note: See TracTickets for help on using tickets.
Back to Top