Opened 2 years ago

Closed 2 years ago

#34046 closed Bug (fixed)

tox.ini contains version pinnings at the wrong places

Reported by: Michael Howitz Owned by: Michael Howitz
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Currently the minimum version numbers are added the section names but they belong inside the sections.
So the flake8 environment does not run flake8 checks but the Django test suite.

Change History (6)

comment:1 by Mariusz Felisiak, 2 years ago

Component: Testing framework → Core (Other)
Triage Stage: Unreviewed → Accepted

Agreed, version restrictions should be move to deps.

comment:2 by Michael Howitz, 2 years ago

Has patch: set

comment:3 by Mariusz Felisiak, 2 years ago

Patch needs improvement: set

comment:4 by Michael Howitz, 2 years ago

Patch needs improvement: unset

comment:5 by Mariusz Felisiak, 2 years ago

Triage Stage: Accepted → Ready for checkin

comment:6 by GitHub <noreply@…>, 2 years ago

Resolution: → fixed
Status: assigned → closed

In 8eed30a:

Fixed #34046 -- Fixed pinning flake8 and isort versions in tox.ini.

Note: See TracTickets for help on using tickets.
Back to Top