Opened 2 years ago
Closed 2 years ago
#33983 closed Cleanup/optimization (invalid)
Unused html code in: password_reset_confirm.html
| Reported by: | Jakob Damgaard Møller | Owned by: | nobody |
|---|---|---|---|
| Component: | Template system | Version: | 4.0 |
| Severity: | Normal | Keywords: | template, cleanup, password_reset_confirm |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Hello, when working on a django site, I was implementing password reset function and used your examples.
I came across this template:
https://github.com/django/django/blob/main/django/contrib/admin/templates/registration/password_reset_confirm.html#L20
And for me, I see no use of line 20 in the template.
And if I do a post with the current html, the username is not posted anyways. So unless the username is for informational usage for the user, it could make sense.
But the input has a class="hidden" and no name is assigned the input.
Am I wrong or right?
Note:
See TracTickets
for help on using tickets.
This was added as part of #31978 (hint for password managers).