#33971 closed Bug (fixed)
admindocs breaks the admin if it appears before the admin in INSTALLED_APPS
Reported by: | Tom Carrick | Owned by: | Mariusz Felisiak |
---|---|---|---|
Component: | contrib.admindocs | Version: | 4.1 |
Severity: | Release blocker | Keywords: | |
Cc: | Carlton Gibson, Alokik Roy | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Change History (8)
comment:1 by , 2 years ago
Summary: | admindocs doesn't work if it appears before the admin in INSTALLED_APPS → admindocs breaks the admin if it appears before the admin in INSTALLED_APPS |
---|
comment:2 by , 2 years ago
Description: | modified (diff) |
---|
comment:3 by , 2 years ago
Cc: | added |
---|---|
Severity: | Normal → Release blocker |
Triage Stage: | Unreviewed → Accepted |
Version: | dev → 4.1 |
follow-up: 8 comment:7 by , 2 years ago
Description: | modified (diff) |
---|
This patch war unnecessary.
with the same Effect we can remove method ready from class AdminDocsConfig(AppConfig) from django.contrib.admindocs.apps
For topik starter:
I use many times admindocs in my projects and it was easy solution: to redefine AdminDocsConfig with empty ready method.
comment:8 by , 2 years ago
Replying to Maxim Danilov:
This patch war unnecessary.
with the same Effect we can remove method ready from class AdminDocsConfig(AppConfig) from django.contrib.admindocs.apps
For topik starter:
I use many times admindocs in my projects and it was easy solution: to redefine AdminDocsConfig with empty ready method.
Removing ready()
was not a proper solution because admindocs
views wouldn't work without it as callbacks wouldn't be registered.
Thanks for the report! Unfortunately the proposed solution doesn't fix this for me, so we need to handle it separately.
Regression in 7f3cfaa12b28d15c0ca78bb692bfd6e59d17bff1.