Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#33886 closed Bug (fixed)

GeoIP module unnecessarily requires GDAL

Reported by: Aarni Koskela Owned by: Aarni Koskela
Component: GIS Version: 4.1
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The commit ​https://github.com/django/django/commit/31bef51d8ea5e3bf650de1495ae1f0566670b8f3 (in versions 4.1a1 forward) moved the import of django.contrib.gis.geos.Point from the def geos() function to top-level, with the unfortunate side-effect that importing the GeoIP module now requires working GDAL libraries.

The GeoIP module should be usable without GDAL; naturally, returning a GDAL geometry would require GDAL.

My suggested fix would be to revert the above commit; a late import should be fine here.

Change History (6)

comment:1 by Aarni Koskela, 2 years ago

Has patch: set

Patch: ​https://github.com/django/django/pull/15906

comment:2 by Claude Paroz, 2 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Mariusz Felisiak, 2 years ago

Severity: Normal → Release blocker

Regression in 31bef51d8ea5e3bf650de1495ae1f0566670b8f3.

comment:4 by Mariusz Felisiak, 2 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

Resolution: → fixed
Status: assigned → closed

In e7afb8a1:

Fixed #33886 -- Reallowed using GeoIP2() when GEOS is not installed.

Regression in 31bef51d8ea5e3bf650de1495ae1f0566670b8f3.

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

In a3ce58ac:

[4.1.x] Fixed #33886 -- Reallowed using GeoIP2() when GEOS is not installed.

Regression in 31bef51d8ea5e3bf650de1495ae1f0566670b8f3.

Backport of e7afb8a18061f664a5d20d409d423b77195e6060 from main

Note: See TracTickets for help on using tickets.
Back to Top