Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#33855 closed Bug (fixed)

System check calls are unnecessary in test worker initialization.

Reported by: Mariusz Felisiak Owned by: Mariusz Felisiak
Component: Testing framework Version: 4.1
Severity: Release blocker Keywords:
Cc: David Smith, Nick Pope, Carlton Gibson Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

3b3f38b3b09b0f2373e51406ecb8c9c45d36aebc added calling system checks to initialization of each test worker. I don't see any reason to do this, it slows down tests (check is called with all databases for each alias and once more in DiscoverRunner.run_tests()) and can cause crashes as some checks require database access.

It seems that it was added to satisfy check_framework.tests.ChecksRunDuringTests.test_registered_check_did_run on spawn. IMO we can skip this test on spawn.

Change History (6)

comment:1 by Mariusz Felisiak, 2 years ago

This also partly explains why tests on MySQL have become so slow.

comment:2 by Mariusz Felisiak, 2 years ago

Has patch: set
Owner: changed from nobody to Mariusz Felisiak
Status: new → assigned

​PR

comment:3 by Carlton Gibson, 2 years ago

Triage Stage: Unreviewed → Accepted

comment:4 by Carlton Gibson, 2 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by GitHub <noreply@…>, 2 years ago

Resolution: → fixed
Status: assigned → closed

In 24effbce:

Fixed #33855 -- Removed unnecessary system check calls from test worker initialization.

Regression in 3b3f38b3b09b0f2373e51406ecb8c9c45d36aebc.

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

In 710af68d:

[4.1.x] Fixed #33855 -- Removed unnecessary system check calls from test worker initialization.

Regression in 3b3f38b3b09b0f2373e51406ecb8c9c45d36aebc.
Backport of 24effbceb871e71d3bc320b91252f743714722df from main

Note: See TracTickets for help on using tickets.
Back to Top