Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#33658 closed Cleanup/optimization (fixed)

Document the "blank" argument of forms.ModelChoiceField.

Reported by: Carsten Fuchs Owned by: Alokik Roy
Component: Documentation Version: 4.0
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

After #26813 and da79ee472d803963dc3ea81ee67767dc06068aac, using a RadioSelect with a forms.ModelChoiceField requires blank=True in order to have the RadioSelect include an empty option. Also see #32434 for a related issue.

However, the argument blank is currently not documented.

Change History (9)

comment:1 by Mariusz Felisiak, 3 years ago

Easy pickings: set
Summary: Undocumented argument `blank` for `forms.ModelChoiceField`Document the "blank" argument of forms.ModelChoiceField.
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization

Agreed. Would you like to prepare a patch?

comment:2 by Alokik Roy, 3 years ago

Owner: changed from nobody to Alokik Roy
Status: newassigned

comment:3 by Carsten Fuchs, 3 years ago

Thanks Alokik Roy for anticipating and taking this! ;-)

comment:5 by Mariusz Felisiak, 3 years ago

Patch needs improvement: set

comment:6 by Alokik Roy, 3 years ago

Patch needs improvement: unset

Implemented suggested changes

comment:7 by Mariusz Felisiak, 3 years ago

Triage Stage: AcceptedReady for checkin

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

Resolution: fixed
Status: assignedclosed

In df225667:

Fixed #33658 -- Doc'd ModelChoiceField.blank attribute.

Thanks Mariusz Felisiak for reviewing.

comment:9 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

In 256db5c0:

[4.0.x] Fixed #33658 -- Doc'd ModelChoiceField.blank attribute.

Thanks Mariusz Felisiak for reviewing.

Backport of df22566748faa7bd16a9616617875e8370cbe4ee from main

Note: See TracTickets for help on using tickets.
Back to Top