Opened 3 years ago
Closed 3 years ago
#33436 closed Cleanup/optimization (wontfix)
Remove test_restrictions_with_no_joining_columns.
| Reported by: | raydeal | Owned by: | nobody |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | 4.0 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I am in doubt what this test exactly test: tests/foreign_object/test_empty_join.py
tests/foreign_object/test_empty_join.RestrictedConditionsTests.test_restrictions_with_no_joining_columns
The test was introduced in #25064, #27392 tickets and two more small changes in test code.
In my opinion the test doesn't test django functionality important from end user point of view or even development. It probably only test the idea of the author. Tested model, its relational fields, are fully customised not using public ORM API, just overwrite class methods.
I would suggest to delete the test because it doesn't bring an important value to django code quality.
Change History (1)
comment:1 by , 3 years ago
| Easy pickings: | unset |
|---|---|
| Resolution: | → wontfix |
| Status: | new → closed |
| Summary: | Test that is not correct (?) → Remove test_restrictions_with_no_joining_columns. |
Note:
See TracTickets
for help on using tickets.
Even though the
Joinis not a public API, we agreed in #25064, that generating invalid SQL is a bug in this case. I don't see any harm in keeping a regression test for #25064.