Opened 3 years ago
Closed 3 years ago
#33310 closed Cleanup/optimization (fixed)
Remove unused "actions.selected" CSS class.
| Reported by: | Álvaro Pelegrina Fernández | Owned by: | Álvaro Pelegrina Fernández |
|---|---|---|---|
| Component: | contrib.admin | Version: | 3.2 |
| Severity: | Normal | Keywords: | |
| Cc: | Carlton Gibson | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
Hello,
First of all I am not sure if this is intended, it's a change happening on Django 3.2
On Django 3.1 this was the admin styling on Select All
And on Django 3.2 it looks like this:
Is it intended? Javascript doesnt add anymore the "selected" class and even if you add it manually it doesnt apply the yellow color because the CSS class just apply the body background color.
If it's intended I think we can refactor and just remove this CSS code at changelist.css (and maybe in other places) because it's indeed (as the comment says) not used and its a bit confusing when overriding it for django admin template overriding purposes.
Change History (6)
comment:1 by , 3 years ago
| Cc: | added |
|---|---|
| Summary: | Django admin Select All CSS seems inconsistent on latest 3.2.9 version → Remove unused "actions.selected" CSS class. |
| Triage Stage: | Unreviewed → Accepted |
comment:3 by , 3 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:4 by , 3 years ago
| Has patch: | set |
|---|
comment:5 by , 3 years ago
Great, I patches those css files.
This is it's related PR https://github.com/django/django/pull/15117
Thanks for the report, we noticed this change when fixing #33083. I think now it looks better, feel-free to removed unused CSS class.