Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#33163 closed Cleanup/optimization (fixed)

Add AppConfig.ready() example to the admonition about connecting receiver functions.

Reported by: Roxane Owned by: Roxane
Component: Documentation Version: 3.2
Severity: Normal Keywords: signals appconfig
Cc: Adam Johnson Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

See https://forum.djangoproject.com/t/load-signals-automatically/9666

My original idea was to import automatically everything in the submodule signals to avoid wondering why the signals do not work. Finally, we setted on detailling the documentation, expanding the "Where should this code live ?" note and including a sample AppConfig

Change History (7)

comment:1 by Roxane, 3 years ago

You can find the PR

comment:2 by Mariusz Felisiak, 3 years ago

Cc: Adam Johnson added
Keywords: appconfig added; documentation app config removed
Patch needs improvement: set
Summary: Detail how to connect signalsAdd AppConfig.ready() example to the admonition about connecting receiver functions.
Triage Stage: UnreviewedAccepted

Thanks for this suggestion. I agree that AppConfig.ready() example would be helpful, but I don't think a separate section is needed.

PR

comment:3 by Mariusz Felisiak, 3 years ago

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:4 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

Resolution: fixed
Status: assignedclosed

In 2d124f6a:

Fixed #33163 -- Added example of connection signal handlers in AppConfig.ready() to docs.

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

In 350d15d7:

[4.0.x] Fixed #33163 -- Added example of connection signal handlers in AppConfig.ready() to docs.

Backport of 2d124f6a1c45afdde8be90c01043e0b14455d41e from main

comment:6 by GitHub <noreply@…>, 3 years ago

In 75ee7057:

Refs #33163 -- Corrected example of connection signal handlers in AppConfig.ready().

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

In 1ab58427:

[4.0.x] Refs #33163 -- Corrected example of connection signal handlers in AppConfig.ready().

Backport of 75ee7057e98dd9725fabb98cabe42966fa4c8222 from main

Note: See TracTickets for help on using tickets.
Back to Top