Admin Sidebar search value stays forever

[Collin Anderson]

I tried out the new admin sidebar search which is really nice, however days later I opened up an admin page and found the sidebar had the _same_ value I had put in days ago.

I think there needs to be some sort of expiration for that value (maybe use sessionStorage?), or it might be better to not saving that value at all between page loads (do we really want to be saving that sort of information in the browser?) I'd expect it to work more like an autocomplete-search to quickly find an item, rather than some sort of persistent filter.

Clicking the x gets rid of the search query too, but I would expect it to go away automatically when navigating to a new page.

[Mariusz Felisiak]

Thanks for the report. IMO we should still preserve typed value (see ​comment), however sessionStorage() seems to be more appropriate.

Marking as a release blocker because this is a bug in the new feature (see d915dd1c5809d7c2bb3679751cd5277571dcd9f7).

[Maxim Milovanov]

hey guys,

I've changed the storage from localStorage to sessionStorage. ​https://github.com/django/django/pull/14917

Thanks for the suggestion.

[Carlton Gibson]

Hi Maxim. Thanks for the patch.

I'll reopen the ticket as it's not "fixed" until that's merged.

[GitHub <noreply@…>]

In 1c802ca:

Fixed #33156 -- Used sessionStorage to preserve quick filter for admin's navigation sidebar.

[Mariusz Felisiak <felisiak.mariusz@…>]

In f6c7e75:

[4.0.x] Fixed #33156 -- Used sessionStorage to preserve quick filter for admin's navigation sidebar.

Backport of 1c802ca2a9d3c66fb723695fe7ea597fb4802402 from main