Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#33128 closed Cleanup/optimization (fixed)

Grammar Issue

Reported by: Matthew Pava Owned by: Joel Farthing
Component: Documentation Version: 4.0
Severity: Normal Keywords: grammar issue
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Matthew Pava)

https://docs.djangoproject.com/en/dev/topics/forms/formsets/#formset-rendering

For Django 4.0, you have the following documentation. In each paragraph, the phrase "as per the forms" needs to be changed to "as per the forms'". (the possessive case)

BaseFormSet.template_name
New in Django 4.0.
The name of the template used when calling str or render(). This template renders the formsets management forms and then each form in the formset as per the template defined by the forms template_name. This is a proxy of as_table by default.

BaseFormSet.template_name_p
New in Django 4.0.
The name of the template used when calling as_p(). By default this is 'django/forms/formsets/p.html'. This template renders the formsets management forms and then each form in the formset as per the forms as_p() method.

BaseFormSet.template_name_table
New in Django 4.0.
The name of the template used when calling as_table(). By default this is 'django/forms/formsets/table.html'. This template renders the formsets management forms and then each form in the formset as per the forms as_table() method.

BaseFormSet.template_name_ul
New in Django 4.0.
The name of the template used when calling as_ul(). By default this is 'django/forms/formsets/ul.html'. This template renders the formsets management forms and then each form in the formset as per the forms as_ul() method.

Change History (10)

comment:1 by Matthew Pava, 3 years ago

Description: modified (diff)

comment:2 by Matthew Pava, 3 years ago

Description: modified (diff)

comment:3 by Matthew Pava, 3 years ago

Description: modified (diff)

comment:4 by Joel Farthing, 3 years ago

Owner: changed from nobody to Joel Farthing
Status: newassigned

comment:5 by Joel Farthing, 3 years ago

Has patch: set

The docs say to just submit a PR if it's a simple fix. As this is my first Django contribution I figured I should walk through the ticket 'claiming' step as well.

PR: https://github.com/django/django/pull/14879

Last edited 3 years ago by Joel Farthing (previous) (diff)

comment:6 by Carlton Gibson, 3 years ago

Triage Stage: UnreviewedAccepted

Yes, thanks. It's difficult to parse correctly without the right punctuation.

comment:7 by Carlton Gibson, 3 years ago

Triage Stage: AcceptedReady for checkin

comment:8 by Mariusz Felisiak, 3 years ago

Severity: Release blockerNormal

comment:9 by Carlton Gibson <carlton.gibson@…>, 3 years ago

Resolution: fixed
Status: assignedclosed

In 2f14432:

Fixed #33128 -- Corrected possessive 's usage in FormSet docs.

comment:10 by Carlton Gibson <carlton.gibson@…>, 3 years ago

In bc0cc82:

[4.0.x] Fixed #33128 -- Corrected possessive 's usage in FormSet docs.

Backport of 2f144323756fc6f8517e357c540f3570356d9eba from main

Note: See TracTickets for help on using tickets.
Back to Top