Opened 3 years ago

Closed 3 years ago

#32905 closed New feature (fixed)

Add `nonform` CSS class for non form errors in FormSets

Reported by: Ties Jan Hefting Owned by: Ties Jan Hefting
Component: Forms Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Ties Jan Hefting)

Forms add the nonfield CSS class for non field errors in ErrorList instances. This is documented in a section on ​rendering form error messages. Similarly, in FormSets I'd expect to see the nonform CSS class added for non form errors. This would allow a custom ErrorList to make a distinction in form field errors, non field errors (forms) and non form errors (FormSets) when rendering error messages. Therefore I'd suggest to add this nonform CSS class and document it for developers to use.

Change History (7)

comment:1 by Ties Jan Hefting, 3 years ago

Owner: changed from nobody to Ties Jan Hefting

comment:2 by Mariusz Felisiak, 3 years ago

Easy pickings: unset
Triage Stage: Unreviewed → Accepted
Type: Cleanup/optimization → New feature

Seems reasonable (similar to #11776).

comment:3 by Ties Jan Hefting, 3 years ago

Description: modified (diff)
Has patch: set

​PR

comment:4 by Mariusz Felisiak, 3 years ago

Patch needs improvement: set

comment:5 by Ties Jan Hefting, 3 years ago

Patch needs improvement: unset

comment:6 by Mariusz Felisiak, 3 years ago

Triage Stage: Accepted → Ready for checkin

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

Resolution: → fixed
Status: assigned → closed

In 84400d2e:

Fixed #32905 -- Added CSS class for non-form errors of formsets.

Note: See TracTickets for help on using tickets.
Back to Top