Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#32754 closed Bug (fixed)

catch_all_view() does not support FORCE_SCRIPT_NAME.

Reported by: SlavaSkvortsov Owned by: SlavaSkvortsov
Component: contrib.admin Version: 3.2
Severity: Release blocker Keywords: FORCE_SCRIPT_NAME catch_all_view final_catch_all_view
Cc: Jon Dufresne Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by SlavaSkvortsov)

catch_all_view returns redirect to '%s/' % request.path_info (script name cut off there) instead of '%s/' % request.path (with the script name)

Patch - ​https://github.com/django/django/pull/14404

Change History (6)

comment:1 by Mariusz Felisiak, 4 years ago

Cc: Jon Dufresne added
Owner: changed from nobody to SlavaSkvortsov
Severity: Normal → Release blocker
Status: new → assigned
Summary: catch_all_view from admin does not support FORCE_SCRIPT_NAME → catch_all_view() does not support FORCE_SCRIPT_NAME.
Triage Stage: Unreviewed → Accepted

Thanks for the report, good catch! Bug in ba31b0103442ac891fb3cb98f316781254e366c3.

comment:2 by SlavaSkvortsov, 4 years ago

Description: modified (diff)

comment:3 by SlavaSkvortsov, 4 years ago

Thank you for a quick answer!

I wrote a patch ​here

comment:4 by Mariusz Felisiak, 3 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

Resolution: → fixed
Status: assigned → closed

In f7691d4:

Fixed #32754 -- Made AdminSite.catch_all_view() respect SCRIPT_NAME.

Regression in ba31b0103442ac891fb3cb98f316781254e366c3.

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

In ce78bc98:

[3.2.x] Fixed #32754 -- Made AdminSite.catch_all_view() respect SCRIPT_NAME.

Regression in ba31b0103442ac891fb3cb98f316781254e366c3.

Backport of f7691d4812c578e696635718e67639d2e08eac40 from main

Note: See TracTickets for help on using tickets.
Back to Top