[patch] form_for_model() should use ChoiceField for any DB field with "choices" set

[brooks.travis@…]

I have a model with a models.CharField(choices=GENDER_CHOICES), but when I run newforms.models.form_for_model() on the model containing that field, and do a print on the resulting form, I get a plain <input type="text">.

[Adrian Holovaty]

Agreed -- good catch.

[ryan.moe@…]

I wasn't sure which fix would be best so I included both. One fixes this in django.db.models.fields by changing all the *Field.formfield() calls, while the other only changes the form_for_model and for_for_instance calls. Both ways worked for the forms I have where this problem was occurring.

[Adrian Holovaty]

Thanks for the patches. I'll have a look.

[Gary Wilson <gary.wilson@…>]

There is also a competing patch in #3401 that alters CharField.formfield() to use ChoiceField for a CharField that has choices.

[Tai Lee]

updated *Field.formfield() methods, with tests.

[Tai Lee]

the last two patches were made out of date by recent changes to django/db/models/fields/init.py, so i've re-implemented this functionality by creating an appropriate Select widget (which can still be overridden if a custom widget is passed in directly) for any form fields that have choices.

i left the implementation in django/db/models/fields/init.py so that it would be useful for anyone wanting to return a form field from a model field, not only when generating a form object with the form_for_* methods.

i also updated tests/modeltests/model_forms/models.py by adding an integer field with choices to the models, updating the expected output, and a comment explaining that any fields with choices defined in the model are represented by a select list (same as foreignkeys).

[Chris Beaven]

Looks good

[Baptiste <baptiste.goupil@…>]

Patch of the #3991, so much simpler (but maybe less powerful, I don't know)

[brosner <brosner@…>]

Baptiste,

Your patch only effects admin display of the widgets. This bug you discovered is an underlying newforms problem that affects form_for_instance and form_for_model. Which is used by newforms-admin (go figure, right) ;)

[Baptiste <baptiste.goupil@…>]

So does the patch of mrmachine since the modified functions are the ones called by form_for_instance & form_for_model, no ?
I think that my patch just factorizes what mrmachine does in its... but I can be wrong !

[Jonas von Poser]

just a heads-up that both attached patches don't work for me anymore at least as of rev. 5063. The widgets in newforms-admin remain simple text input fields with either one.

[Tai Lee]

i've not used the newforms-admin branch. does it use form_for_model? is this a problem or conflict with that branch, or a problem with this patch? does it still work for your own form_for_models forms?

[Jonas von Poser]

Oh, I'm sorry. Both patches work with newforms-admin, they're just off by a few lines each, so basically it was me being unable to use patch correctly. I should learn to double-check before updating any bugs. :-/ Apologies.

[Malcolm Tredinnick]

(In [5119]) Fixed #3268 -- Changed default model formfields to use a select widget when the
field has a choices attribute. Based on a patch from mrmachine.