#32639 closed New feature (wontfix)
ADMINS and MANAGERS may contain invalid email addreses
| Reported by: | Matthias Kestenholz | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (System checks) | Version: | 4.0 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I propose a new system check which prevents users from configuring invalid email addresses.
Change History (3)
comment:1 by , 4 years ago
comment:2 by , 4 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | assigned → closed |
Thanks for this proposition, however I don't think that we need extra checks, because we will probably introduce some regressions with them (like we did in the past). Email validation is too fragile.
comment:3 by , 4 years ago
Thanks!
I tend to agree that adding checks is bothersome, especially since I have been bitten by new checks in the past. However, mail_managers and friends will choke later anyway and it would be better to catch typos earlier. Django's EmailValidator is battle tested and has been essentially unchanged since 2015 and building on this should (yeah I know, famous last words) be safe. root@localhost etc. are valid according to the EmailValidator so I really have a hard time imagining regressions. Also, such regressions would be detected very early, when starting up the application server, not in the middle of the night when everyone is sleeping.
Because of these points I still think this new check would be a good idea.
Of course it is your call. Thanks again :)
PR