Opened 4 years ago

Closed 3 years ago

#32499 closed Cleanup/optimization (fixed)

simplify_regex only removes some metacharacters from regex patterns

Reported by: Rohith P R Owned by: Nick Pope
Component: contrib.admindocs Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Input Pattern Expected Output Actual Output
r'^\b(?P<slug>\w+)\B' /<slug> /\b<slug>\B
r'\Ab/\Z' /b/ /\Ab/\Z

Change History (12)

comment:1 by Nick Pope, 4 years ago

Triage Stage: UnreviewedAccepted
Version: 3.1master

comment:2 by Mariusz Felisiak, 4 years ago

Patch needs improvement: set

comment:3 by Rohith P R, 4 years ago

Patch needs improvement: unset

comment:4 by Mariusz Felisiak, 4 years ago

Patch needs improvement: set

comment:5 by Nick Pope, 3 years ago

Owner: changed from Rohith P R to Nick Pope
Patch needs improvement: unset

New PR.

comment:6 by Mariusz Felisiak, 3 years ago

Patch needs improvement: set

comment:7 by Nick Pope, 3 years ago

Patch needs improvement: unset

comment:8 by Mariusz Felisiak, 3 years ago

Triage Stage: AcceptedReady for checkin

comment:9 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

In 27189af:

Refs #32499 -- Added metacharacters helper for simplify_regex().

comment:10 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

In 9f7809ec:

Refs #32499 -- Added more tests for simplify_regex().

comment:11 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

In 85540da9:

Refs #32499 -- Fixed escaped metacharacters in simplify_regex().

comment:12 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

Resolution: fixed
Status: assignedclosed

In 448d974:

Fixed #32499 -- Escaped additional metacharacters in simplify_regex().

Note: See TracTickets for help on using tickets.
Back to Top