Opened 4 years ago

Closed 4 years ago

#32395 closed Cleanup/optimization (fixed)

Migrate signals verbose stdout emissions are not capturable

Reported by: Simon Charette Owned by: Simon Charette
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The migrate command takes a --verbosity flag that is passed down to emit_pre_migrate_signal and emit_post_migrate_signal functions but these are not provided which stdout the output should be directed to. This makes testing migrate -v2 through call_command pollute sys.stdout when it should be directed to the provided stdout as discovered in https://github.com/django/django/pull/13890#pullrequestreview-579320176

Change History (6)

comment:1 by Simon Charette, 4 years ago

Has patch: set

comment:2 by Mariusz Felisiak, 4 years ago

Owner: changed from nobody to Simon Charette
Status: newassigned
Triage Stage: UnreviewedAccepted
Version: 3.1master

comment:3 by Mariusz Felisiak, 4 years ago

Needs documentation: set

comment:4 by Simon Charette, 4 years ago

Needs documentation: unset

comment:5 by Mariusz Felisiak, 4 years ago

Triage Stage: AcceptedReady for checkin

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: fixed
Status: assignedclosed

In f23b056:

Fixed #32395 -- Allowed capturing stdout of migration signals.

Note: See TracTickets for help on using tickets.
Back to Top