Opened 4 years ago

Closed 4 years ago

#32166 closed Cleanup/optimization (fixed)

Remove redundant Greatest class in test_expression_on_aggregation

Reported by: Sicong Owned by: Sicong
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Function greatest now supported in db.models.functions.comparison, propose to remove class Greatest in the unit test.

Refer to comment on Github:​https://github.com/django/django/commit/f59fd15c4928caf3dfcbd50f6ab47be409a43b01#diff-7406fc41610281c9ff732230a859d1eb1406875841d9a5a81ab4c7090b37b6d0R920

Change History (4)

comment:1 by Sicong, 4 years ago

Owner: changed from nobody to Sicong
Status: new → assigned

I have a patch ready.

comment:2 by Mariusz Felisiak, 4 years ago

Component: Testing framework → Core (Other)
Triage Stage: Unreviewed → Accepted

Thanks. Please send PR via GitHub.

Ticket is not required for such a small cleanups, by the way.

comment:3 by Tim Graham, 4 years ago

Has patch: set
Summary: test_expression_on_aggregation has an additional "class Greatest" definition → Remove redundant Greatest class in test_expression_on_aggregation
Triage Stage: Accepted → Ready for checkin

​PR

comment:4 by GitHub <noreply@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In 09e1ec7:

Fixed #32166 -- Removed redundant definition of Greatest in test_expression_on_aggregation.

Note: See TracTickets for help on using tickets.
Back to Top