Opened 4 years ago

Closed 4 years ago

#32121 closed Bug (fixed)

Skip auth.E003 system check for USERNAME_FIELD with total UniqueConstraints.

Reported by: Hannes Ljungberg Owned by: Hannes Ljungberg
Component: Core (System checks) Version: 3.1
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Defining a user model like this:

class User(AbstractBaseUser):
    username = models.CharField(max_length=30)
    USERNAME_FIELD = "username"

    class Meta:
        constraints = [UniqueConstraint(fields=["username"], name="user_username_unq")]

Will trigger auth.E003:

auth.User: (auth.E003) 'User.username' must be unique because it is named as the 'USERNAME_FIELD'.

Sometimes it’s not preferable to set the field as unique with unique=True as it will create an extra implicit *_like index for CharField and TextField on PostgresSQL. The system check should be extended to check for the presence of USERNAME_FIELD in Model._meta.constraints. Not really sure if this classifies as a bug.

Change History (5)

comment:1 by Hannes Ljungberg, 4 years ago

Has patch: set

PR: ​https://github.com/django/django/pull/13568

comment:2 by Mariusz Felisiak, 4 years ago

Summary: User.USERNAME_FIELD unique check trigger even if the field is set as unique with UniqueConstraint → Skip auth.E003 system check for USERNAME_FIELD with total UniqueConstraints.
Triage Stage: Unreviewed → Accepted

comment:3 by Mariusz Felisiak, 4 years ago

Patch needs improvement: set

comment:4 by Mariusz Felisiak, 4 years ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In f7963615:

Fixed #32121 -- Fixed detecting uniqueness of USERNAME_FIELD when using Meta.constraints.

Co-authored-by: Simon Charette <charettes@…>

Note: See TracTickets for help on using tickets.
Back to Top