#32091 closed Bug (fixed)
Admin search input on small widths is too small with selected list filter
Reported by: | Timothy Schilling | Owned by: | tim-schilling |
---|---|---|---|
Component: | contrib.admin | Version: | 3.1 |
Severity: | Release blocker | Keywords: | css admin |
Cc: | Tom Carrick | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The search input shrinks down to an unusable level when the window's width is too small. This only occurs when there's a selected list filter causing the 10 results (100 total)
span to appear. This should be reproducible from the admin where there's a search field and a list filter selected. Simply make the window skinny.
I've only tested this on FF on Ubuntu, but my colleague reported it with Chrome.
I've confirmed a fix in contrib/admin/css/responsive.css
by changing the following style:
#changelist-search .quiet { width: 100%; margin: 5px 0 0 25px; }
to
#changelist-search .quiet { flex: 1 0 auto; width: 0; margin: 5px 0 0 25px; }
This matches the #searchbar style above it.
You can see the problem in my screenshots. The immediate resolution for users is to make the window slightly larger.
I will be creating a PR for this shortly.
Attachments (2)
Change History (7)
by , 4 years ago
Attachment: | search_skinny_window.png added |
---|
by , 4 years ago
Attachment: | search_wide_window.png added |
---|
View showing the search input with a slightly wider window.
comment:1 by , 4 years ago
Component: | Uncategorized → contrib.admin |
---|---|
Has patch: | set |
Keywords: | css admin added |
PR on github: https://github.com/django/django/pull/13517
comment:2 by , 4 years ago
Cc: | added |
---|---|
Owner: | changed from | to
Severity: | Normal → Release blocker |
Status: | new → assigned |
Triage Stage: | Unreviewed → Accepted |
Type: | Uncategorized → Bug |
Great catch, thanks.
Regression in 8ee4bb6ffcb3346c0fa8fb194986fbf9edadc822.
comment:3 by , 4 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
View showing the search input as too small with a skinny window.